Pillar: P0 Trust (umbrella #586). One small pull, follows #699 (merged as #725). Found in its security review.
Outcome. A report that was accepted always has its issue's number, and the outbox always hears of it, whatever fails afterwards.
Today.acceptReport (src/actions/reports.ts) opens the issue, then labels it, then notes the number on the report and appends report.accepted. If labelling throws, the issue exists but the report stays accepted with no number and no event: it is in no queue and cannot be accepted again.
Acceptance.
[ ] The number is noted and the event appended as soon as the issue has opened, before labelling.
[ ] A test that makes labelling fail: the report is accepted with its number, the issue is there under its marked title, the event is in the outbox once, and a second accept is refused as decided with no second issue.
Done means reachable: page and API do not change; the test is the proof; no look.
Pillar: P0 Trust (umbrella #586). One small pull, follows #699 (merged as #725). Found in its security review.
Outcome. A report that was accepted always has its issue's number, and the outbox always hears of it, whatever fails afterwards.
Today.
acceptReport(src/actions/reports.ts) opens the issue, then labels it, then notes the number on the report and appendsreport.accepted. If labelling throws, the issue exists but the report stays accepted with no number and no event: it is in no queue and cannot be accepted again.Acceptance.
Done means reachable: page and API do not change; the test is the proof; no look.
Start from: src/actions/reports.ts, test/reports.test.ts.
Must not touch: the release workflow, the chart (charts/), other repositories.