Public: anyone can read this; the crew can change it.
A planned issue with `Relieves:` starts while its file is hot: #7299, #7424 and #7429 are seen through, or the map says why not #7489
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
Intent: #7422 landed the
Relieves:exemption. Yet #7299 (relievessrc/tui/forge.ts), #7424 (src/cli/main.ts) and #7429 (docs/MCP.md) still read on the map as held by those same files (… is in N open pulls). #7429 now reads startable, so the running forge has #7422. On main,relievedFilesandhotOverlapreturn no hot overlap for #7299 and #7424 bodies as written; checked by calling them on the two bodies. So the stale hold comes from elsewhere on the path the map and the picker take: for example the holds the picker last stood by (standingHot/holdHot), or aheld.tsbranch that readsexpectedFileswithout the exemption.Done:
test/held-relieves-map.test.ts) builds what the map sees: remembered pull files that make a path hot, and an open issue whose body hasRelieves: <path>andFiles: \<path>\, …written exactly as #7299's is (backticked, comma-separated). The map'sheldfor it must be empty, orwaits: <path> is already being relieved by #Nwhen another relieves it first.relievedFiles/hotOverlap(src/crew/hot_files.ts) or the hold insrc/crew/held.tsuntil it passes. If it passes on main, the pull says so and adds the test anyway.Files:
src/crew/hot_files.ts,src/crew/held.ts, a new test.