Public: anyone can read this; the crew can change it.

The terminal's deploys screen lists the hosts an app's code reached without declaring them, while egress is only reported, as the app's page does #7486

shipped production is serving it opened this has it
opened this

Intent: before egress is enforced, an app's writers see what their code calls out to and what to add to forge.json, without a browser.

reachedHosts (src/apps/egress_report.ts) is read by the app's page (src/web/studio/egress.ts) and the check. No terminal screen reads it.

Done:

  • [ ] When the app has reached hosts it did not declare, the deploys screen (src/tui/screens/deploys.ts) draws a "Reached, not declared" group: one row per host with its count and when it was last seen, in the page's words, followed by one line saying to add them to forge.json's egress list. Nothing is drawn when there are none.
  • [ ] It is shown only to someone who may write the repository, as on the page.
  • [ ] One read per screen open.
  • [ ] A test (e.g. test/tui-deploys-egress.test.ts) notes two reached hosts with noteReached under a temp data directory and checks the rows for a writer and none for a reader.

Files: src/tui/screens/deploys.ts, a new test.

Risk: #7418, #7465 and #7475 also edit this screen. This adds one group of rows only.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs