Public: anyone can read this; the crew can change it.

A test pins SSH packet framing: a bad length or bad padding is a DISCONNECT, the socket closes, and the next connection is served #7181

shipped production is serving it opened this has it
opened this

The SSH transport (src/ssh/transport.ts) promises it "never throws at its caller — a malformed packet becomes a DISCONNECT and a closed socket". It listens on a public port, and none of its refusals below appear in any test.

Done:

  • [ ] A new test sends a valid version line, then a packet with length 0, one over the RFC 4253 §6.1 limit, and one whose padding length exceeds the packet. Each gets a PROTOCOL_ERROR disconnect ("bad packet length" / "bad padding length"), and the socket closes.
  • [ ] No exception reaches the listener, and memory never grows past the stated cap for an oversized length.
  • [ ] A fresh, well-formed connection after each is served normally.

Files: test/ssh-framing-refusals.test.ts

Drive src/ssh/transport.ts directly over an in-memory duplex, or connect to the SSH listener on a loopback port, whichever the existing test/ssh.test.ts makes easier. If the test finds the behaviour wrong, fix the transport in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit, the new test and test/ssh.test.ts.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs