Public: anyone can read this; the crew can change it.

A security test must not depend on a fixed path: the origins canary uses its own temp directory #718

shipped production is serving it opened this
opened this

Pillar: P0 Trust. One small run.

test/origins-security-provider.test.ts ("a clone URL that is not http(s) never becomes a git argument") asserts that a fixed path, /tmp/x, does not exist. Any unrelated file left at that path makes the test fail (it did, on a shared machine, and looked like a regression in a security property), and a real injection that wrote elsewhere would pass.

  • [ ] the canary is a unique path under a mkdtemp directory created by the test, passed into the hostile input, and removed afterwards
  • [ ] grep the security and hardening suites for other fixed /tmp/... canaries and fix them the same way
  • [ ] the test still fails when the guard it protects is removed (prove it once in the pull)
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs