Public: anyone can read this; the crew can change it.

A test pins contributing when the fork never arrives or its mirror fails: the answer says so and nothing is half-made #7152

shipped production is serving it opened this has it
opened this

contribute in src/actions/contribute.ts answers fork_timeout when the origin's fork does not appear in time, and mirror_failed when the workbench mirror cannot be made. No test names either.

Done, with the fake origin (test/fake-origin.ts):

  • [ ] A new test: a fake origin that never shows the fork leads to fork_timeout, with a shortened wait injected for the test. No branch, commit or pull is made.
  • [ ] A fake origin whose clone fails leads to mirror_failed. No local mirror repository is left behind.
  • [ ] The API's answer for each is a refusal in words, not a 500.

Files: test/contribute-fork-failures.test.ts

If the test finds the behaviour wrong, fix the tool in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs