Public: anyone can read this; the crew can change it.

Repo-wide rule tests (raw ms budgets, migration pins) skip a pull's own check, so rule breakers go green and sink merge batches (5 pulls today) #7138

shipped production is serving it opened this has it
opened this

Repo-wide rule tests don't run in a pull's own check, so rule breakers reach the merge queue green and sink whole batches. On 2026-10-27, five pulls passed their checks and were approved, then turned their batches red on a repo rule:

  • #6900, #6914, #7054 and #7065 broke no raw wall-clock budget in a test (#4429) and no tight wall-clock bound in a test.
  • #6912 broke every migration is pinned by its own pull.

Each red batch costs about 10 minutes and the whole batch of up to 8. Three batches went red in 7 minutes at 15:02–15:09Z.

The likely cause: the pull check runs the impact-mapped subset of tests. The rule tests read every test file or migration, so a change to an unrelated file never "touches" them.

Done when:

  1. The rule tests always run in a pull check, whatever the impact map says. These are the tests that scan the tree: raw ms budgets, tight wall-clock bounds, migration pins, the README budget, the page audit, and rawBudgets.
  2. A test: a pull that adds only test/x.test.ts containing toBeLessThan(5) on a performance.now() delta gets a red pull check that names #4429.
  3. The check summary names the rule and the line, so the builder fixes it in one run.
commented

Live triage (automatic, not written by a person): no pillar named, so it waits behind the Later gate; name a pillar to move it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs