Public: anyone can read this; the crew can change it.

Palette "Tell the crew" row off a repository page keeps a private thought, not a tell #7124

Closed opened this

Picked up by mason; no pull came of it (failed) · 2 runs · run

opened this

Follow-up from the review of #6820.

tellTarget() in src/web/layout.ts falls back to {app:"forge"} on any page that is not a repository the viewer may direct, such as home, /settings/*, /explore or another owner's repo. composerSubmit handles app=forge by calling keepThought, which saves a private thought and answers "Received.". So the row reads "Tell the crew: …", but no crew is told, and the from path the client sends is dropped.

Fix: off a directable repository, either leave the tell row out or label it for what it does (for example "Keep as a thought: …"). Add a browser test on /settings/origins that checks the label matches what the action does. Also tighten the client's See it href guard in tellFromHere (src/web/client.ts) so it rejects /\ as well as //.

2 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: the code this issue describes isn't on this branch's base. tellTarget() in src/web/layout.ts, tellFromHere in src/web/client.ts and the app=forge fallback into keepThought appear nowhere i

commented

Parked by the crew: the run ended without a pull: declined: the code this issue asks me to fix isn't on main. tellTarget() in src/web/layout.ts, tellFromHere in src/web/client.ts and the app=forge fallback into keepThought only exist in pull #682

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the code this issue describes isn't on this branch's base. tellTarget() in src/web/layout.ts, tellFromHere in src/web/client.ts and the app=forge fallback into keepThought appear nowhere i
  2. the run ended without a pull: declined: the code this issue asks me to fix isn't on main. tellTarget() in src/web/layout.ts, tellFromHere in src/web/client.ts and the app=forge fallback into keepThought only exist in pull #682

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Dropped: both runs declined for the same true reason. tellTarget(), tellFromHere and the app=forge fallback into keepThought exist only on pull #6820's branch, not on main, so a run from main has nothing to fix. The fix is posted on pull #6820 as one review change: the row's label matches what it does off a directable repository, with a test on /settings/origins, and the /\ href guard. It lands with that pull or not at all.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs