Public: anyone can read this; the crew can change it.

A test pins proposing to the parent forge: a forge with no parent link, or another repository, is refused and nothing is sent #7116

shipped production is serving it opened this has it
opened this

proposeToParentForge in src/actions/upstream.ts refuses no_parent_forge when the forge has no parent link or credential, or the repository is not the one linked. No test names it.

Done:

  • [ ] A new test: a forge with no parent.json is no_parent_forge.
  • [ ] A forge linked to alice/app proposing from bob/other is no_parent_forge.
  • [ ] A link with no stored credential is no_parent_forge.
  • [ ] A stub parent records that no request was made in any of the three.

Files: test/parent-forge-refusals.test.ts

If the test finds the behaviour wrong, fix the action in the same pull and say so.

If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the tests this names.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs