Public: anyone can read this; the crew can change it.

A test pins redeploying an app environment: with no runtime, or nothing to deploy, it says so and starts nothing #7105

shipped production is serving it opened this has it
opened this

redeployEnv in src/actions/apps.ts refuses no_such_env, no_runtime and nothing_to_deploy, and no test names the last two.

Done:

  • [ ] A new test: on a forge with no apps runtime, redeploying is no_runtime.
  • [ ] With a runtime stub and an environment that has no commit yet, it is nothing_to_deploy.
  • [ ] An environment name isEnvName rejects is no_such_env.
  • [ ] After each refusal, no deploy run was created.

Files: test/redeploy-refusals.test.ts

If the test finds the behaviour wrong, fix the action in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs