Public: anyone can read this; the crew can change it.

A test pins changing quotas and capacity: an unknown key is refused, and nothing in the batch is applied #7104

shipped production is serving it opened this has it
opened this

changeQuotas in src/actions/quotas.ts refuses an unknown key with no_such_quota, and changeCapacity in src/actions/capacity.ts with no_such_setting. No test names either.

Done:

  • [ ] A new test: a forge admin changes two quotas, one known and one unknown. The answer is no_such_quota, and the known one is not applied either.
  • [ ] An unknown capacity key is no_such_setting, and the capacity read is unchanged.
  • [ ] A non-admin is refused before any key is looked at.

Files: test/quota-capacity-keys.test.ts

If the test finds the behaviour wrong, fix the action in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs