Public: anyone can read this; the crew can change it.

A test pins removing a secret that is not there: `no_such_secret`, and nothing else in that scope changes #7102

shipped production is serving it opened this has it
opened this

removeSecret in src/actions/secrets.ts refuses a name that does not exist with no_such_secret, and no test names it.

Done:

  • [ ] A new test: a forge admin removes an unknown name at forge, org and repository scope, and each is no_such_secret. The secrets that do exist in that scope are all still there.
  • [ ] The same name existing at another scope is not removed.
  • [ ] A non-admin gets not_found, never no_such_secret, so the refusal never says what exists.

Files: test/secret-remove-missing.test.ts

If the test finds the behaviour wrong, fix the action in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs