Public: anyone can read this; the crew can change it.

A test pins review and comment bounds: more than 50 line comments, or an empty comment, is refused and nothing is written #7087

shipped production is serving it opened this has it
opened this

submitReview in src/actions/pulls.ts refuses more than MAX_REVIEW_LINES (50) line comments with too_many_lines. addCommentThrough in src/actions/issues.ts refuses an all-whitespace body with empty_body. No test names either.

Done:

  • [ ] A new test submits a review with 51 line comments through the API and gets the refusal. No review and no comment are stored.
  • [ ] Exactly 50 succeeds.
  • [ ] A comment of spaces and newlines is refused through the API and MCP alike, and the thread is unchanged.

Files: test/review-comment-bounds.test.ts

If the test finds the behaviour wrong, fix the action in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs