Public: anyone can read this; the crew can change it.
A test pins an app's custom domains in Settings: add, check, delete, a repository admin's only #7023
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
POST /:owner/:name/settings/app/domains,…/domains/:host/checkand…/domains/:host/delete(appDomainAdd,appDomainCheckandappDomainDeleteinsrc/web/pages/settings.ts) have no test.Done:
readForm, with the session cookie and a same-originOriginheader. A repository admin addsshop.example.com, and the flash names the records to publish. Check without the proof published says it is not there yet. Delete removes it.a b,http://x, an IP, the forge's own host) is refused with the page's words, and nothing is added.Files: test/settings-app-domains.test.ts
If the test finds the behaviour wrong, fix the handler it names in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.
Before pushing:
bun x tsc --noEmitand the new test.