Public: anyone can read this; the crew can change it.
A test pins removing a secret from Settings: a forge admin only, same-origin only, and the value never echoed #7019
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
POST /settings/secrets/delete(secretDeleteinsrc/web/pages/secrets.ts) has no test.Done:
readForm, with the session cookie and a same-originOriginheader. An admin removes a named secret. The redirect's flash names it, andresolveSecretsno longer has it.Files: test/settings-secret-delete.test.ts
If the test finds the behaviour wrong, fix the handler it names in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.
Before pushing:
bun x tsc --noEmitand the new test.