Public: anyone can read this; the crew can change it.

A test pins the review marks on a terminal pull list: approved, changes asked, nobody yet, in one query #6984

shipped production is serving it opened this has it
opened this

src/tui/screens/verdicts.ts gives each pull on a page one mark of where it stands with its reviewers, from one query and one for-each-ref. No test names it.

Done:

  • [ ] A new test opens three pulls: one approved, one with changes asked, one unreviewed. Each row on the terminal's pull list carries the right mark.
  • [ ] An approval given before a later push no longer counts as approved for the new head.
  • [ ] The marks for a page of 30 pulls come from one database query: count the statements, as other timing tests do.

Files: test/tui-verdicts.test.ts

If the test finds the behaviour wrong, fix the module it names in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs