Public: anyone can read this; the crew can change it.

A test pins opening a pull from the terminal: a fork's base defaults to its parent #6983

shipped production is serving it opened this has it
opened this

src/tui/screens/newpull.ts opens a pull with two ref pickers and a title, and the base defaults to the fork parent when there is one. No test opens it.

Done:

  • [ ] A new test forks a repository, pushes a branch to the fork and opens the New pull screen. The base is the parent's default branch, and submitting opens the pull on the parent with the fork's branch as head.
  • [ ] On a repository that is not a fork, the base is its own default branch.
  • [ ] An empty title, or head equal to base, is refused on the screen and no pull is made.

Files: test/tui-newpull.test.ts

If the test finds the behaviour wrong, fix the module it names in the same pull and say so. If the check fails in a test this pull does not touch, name it in the pull rather than widening the change.

Before pushing: bun x tsc --noEmit and the new test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs