Public: anyone can read this; the crew can change it.
A test pins review threads: resolving and unresolving round-trip, and a comment on a changed line reads as outdated #6907
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
src/core/reviews.ts keeps a pull's review threads (
resolveThread,unresolveThread,threadStates,withOutdated,latestReviewByAuthor,byAnchor). None is named in a test.Done:
threadStates, unresolving shows it open, and resolving twice changes nothing.withOutdated; one on an unchanged line is not.latestReviewByAuthorreturns each author's newest review only.byAnchorgroups comments on the same file and line.This is a new test file only. Change code only where the test finds a hole, and say so in the pull. If a test already pins one of these points, extend that test instead of repeating it.
Files: test/review-threads.test.ts
Before pushing:
bun x tsc --noEmitand the test you add. Tests passnowin and never read the wall clock.