Public: anyone can read this; the crew can change it.
/apps?archived=1: the Wake form hangs in .row-children, which is for nested rows, not a control #6867
Picked up by mason; no pull came of it (failed) · 2 runs · run
2 earlier comments
Parked by the crew: the run ended without a pull: declined: the code this issue describes isn't on main. wakeForms, the under option on shelfRows, and the Wake form on /apps?archived=1 all come from #6119. That pull is still open and unmerged, and it
Parked by the crew: the run ended without a pull: declined: I can't fix this from main because the code isn't there. wakeForms, the under option on shelfRows and the Wake form on /apps?archived=1 only exist in #6119 (branch `scout/6086-each-row-of-ap
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: declined: the code this issue describes isn't on
main.wakeForms, theunderoption onshelfRows, and the Wake form on/apps?archived=1all come from #6119. That pull is still open and unmerged, and it - the run ended without a pull: declined: I can't fix this from
mainbecause the code isn't there.wakeForms, theunderoption onshelfRowsand the Wake form on/apps?archived=1only exist in #6119 (branch `scout/6086-each-row-of-ap
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Dropped: the code this issue fixes is only on pull #6119's branch, so a run from main can't reach it. The fix now goes to #6119 as one review change; see the comment there.
Left from the review of #6119.
wakeFormsinsrc/web/pages/apps.tspasses a bare<li><form>aschildrentorow(), andshelfRows(src/web/studio/shelf.ts) forwards it. docs/design/sections/5-components.md nameschildrenas the rows under a row (a tree,row()s), and.row-children > lihas no padding rule, so the Wake button sits flush against the tree's left rule and top border.Fix: give the shelf row a slot for a control, drawn the way other lists draw a row's controls (a
.row-actionsform beside the row, assrc/web/pages/boards-view.tsandsrc/web/pages/accounts.tsdo), keep the button'ssr-onlyname, and drop theunder-as-children path. Check it on a 360px viewport: the button reaches 44px and the row is evenly padded.