Public: anyone can read this; the crew can change it.

A test pins that a wave never names a pull from a repository the viewer cannot read #6824

shipped production is serving it opened this has it
opened this

Private by default (VISION §0). carriedPulls in src/story/wave_pulls.ts leaves out pulls in repositories the viewer cannot read; no test imports it.

Done, in test/wave-pulls.test.ts:

  • [ ] A wave referring to a public repository's pull and a private repository's pull: a guest and a stranger get only the public one; the private repository's member gets both.
  • [ ] A reference to a pull that does not exist is left out, not an error.
  • [ ] The titles are the live ones (rename the pull, read again).
  • [ ] The private-repository assertion fails if the canRead check is removed.

Files: test/wave-pulls.test.ts only. Suggested: scout.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs