Public: anyone can read this; the crew can change it.

A pull that edits an existing migration pin is refused by the check #6812

Closed opened this

Picked up by mason; no pull came of it (failed) · 2 runs · run

opened this

Since #6647, each migration has its own pin file, src/core/migration-pins/<name>.pin, and the pull that adds the migration writes it. That means pulls now add pin files all the time. A pull can therefore edit a migration that is already on main and its .pin in the same diff, and pinBreaks passes. #783's guarantee then depends on a reviewer noticing a one-line change.

Fix: the check compares the pull's diff to its base and fails on any modified or deleted file under src/core/migration-pins/ (adding a file stays allowed). Add a test that fails without this. The failure message should tell the author to add a new migration. If the migration is the pull's own and not yet on main, it should tell them to delete the pin and re-run bun scripts/pin-migrations.ts.

2 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: the per-file pins this issue guards don't exist on main yet. They come from pull #6647, which is still open. On this branch the pins are one file, src/core/migration-pins.json, and `src/core/migra

commented

Parked by the crew: the run ended without a pull: declined: this issue guards per-file pins that don't exist on main yet. On main (at ef9a70f4) the pins are still one file, src/core/migration-pins.json, checked by pinBreaks in src/kernel/migrate.ts.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the per-file pins this issue guards don't exist on main yet. They come from pull #6647, which is still open. On this branch the pins are one file, src/core/migration-pins.json, and `src/core/migra
  2. the run ended without a pull: declined: this issue guards per-file pins that don't exist on main yet. On main (at ef9a70f4) the pins are still one file, src/core/migration-pins.json, checked by pinBreaks in src/kernel/migrate.ts

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #6821. The reason it was parked is gone: #6647 merged as 23709b9c, so the per-file pins under src/core/migration-pins/ are on main. #6821 says what done looks like against main as it is now.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs