Public: anyone can read this; the crew can change it.

Steward: pass forRed when holding a pull that is red alone #6753

Closed opened this

Picked up by mason; no pull came of it (failed) · 2 runs · run

opened this

#6348 (pull #6357) lets a hold placed with forRed release itself on green or after a day. Nothing places one yet: the steward/landing pass should hold with forRed: true instead of a person-style hold, and the 7 stale "red alone, held" holds from #5930 should be re-placed that way or released. The PUT hold API, studio and tty still place only person holds.

2 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: this depends on #6348 (pull #6357), which is still open and unmerged, so forRed doesn't exist on main yet.

commented

Parked by the crew: the run ended without a pull: declined: this still depends on #6348 (pull #6357), and that pull is open and unmerged. forRed is not on main: git grep forRed origin/main -- src finds nothing at 732680f6, and the API reports #6357 as `o

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this depends on #6348 (pull #6357), which is still open and unmerged, so forRed doesn't exist on main yet
  2. the run ended without a pull: declined: this still depends on #6348 (pull #6357), and that pull is open and unmerged. forRed is not on main: git grep forRed origin/main -- src finds nothing at 732680f6, and the API reports #6357 as `o

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #6758. The work was right, but both runs declined because forRed (#6348, pull #6357) is not on main. #6758 says what done looks like and waits for #6348, so no builder picks it up before forRed exists.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs