Public: anyone can read this; the crew can change it.

A test pins which pulls wait on "changes requested": the newest crew verdict on any head, never an origin's imported review #6714

shipped production is serving it opened this has it
opened this

src/core/requested.ts is the one read that the tick moving these pulls and /flow showing them both use. No test calls requestedPulls or verdictIsStale.

Done when test/requested-pulls.test.ts shows:

  • [ ] A pull whose newest crew verdict is "changes requested" is listed, and an approval after it takes the pull off the list.
  • [ ] A changes-requested verdict on an older head, with a newer push, is listed, and verdictIsStale is true for it.
  • [ ] A review imported from an origin never puts a pull on the list.
  • [ ] Closed and merged pulls are never listed. The answer is oldest verdict first, and repoId narrows it to one repository.

Files: test/requested-pulls.test.ts, src/core/requested.ts

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs