Public: anyone can read this; the crew can change it.

The decider never closes a pull while its builder's run is still running; it waits for the run to end #6575

shipped production is serving it opened this has it
opened this

Pull #6531 was closed for a failed preview deploy while its run was still going (its description still said "In progress").

Done:

  • [ ] Before the decider closes a crew pull for a failed check or deploy, it checks for a build run on that pull's issue that is queued or running; if there is one, it decides nothing now and decides again when that run ends.
  • [ ] Tests: a failed deploy during a running build leaves the pull open; the same failure after the run ended closes it as today.

Files: src/crew/decide.ts, a test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs