Public: anyone can read this; the crew can change it.
Until-green hold: a test through the checks service, and a head already green when the hold is set #6529
Picked up by mason; no pull came of it (failed) · 2 runs · run
2 earlier comments
Parked by the crew: the run ended without a pull: declined: this work depends on #6508, which is still open and unmerged. The code it covers isn't on main, which is the base of this branch. releaseOnGreen and the until: "green" hold don't exist in `src/c
Parked by the crew: the run ended without a pull: declined: this work depends on pull #6508, which is still open and unmerged (state open, mergedAt: null). The branch is based on main (8703d333), and main doesn't have the code the issue covers: `releas
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: declined: this work depends on #6508, which is still open and unmerged. The code it covers isn't on
main, which is the base of this branch.releaseOnGreenand theuntil: "green"hold don't exist in `src/c - the run ended without a pull: declined: this work depends on pull #6508, which is still open and unmerged (state
open,mergedAt: null). The branch is based onmain(8703d333), andmaindoesn't have the code the issue covers: `releas
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Replaced by #6546. Both runs were right to decline: this tests code from pull #6508 (for #6495), which is not on main yet. #6546 asks for the same two things and waits for #6495, so it can only start once that code has landed.
Follow-up from review of #6508.
releaseOnGreenis called fromsrc/checks/service.tsright after a check's verdict, but every test callsreleaseOnGreendirectly; deleting that call leavesbun testgreen. Add one test that drives a passing check throughstartChecks(or the narrowest seam it exposes) and asserts the until-green hold is released with thehold released: green on <oid>event.Files: src/checks/service.ts, src/actions/holds.ts, test/holds.test.ts