Public: anyone can read this; the crew can change it.

A changes-asked review post ranks above an approval of the same age on home #6469

shipped production is serving it opened this has it
opened this

Part 3 of #5823. Asking for changes needs someone to act; an approval is news.

Done:

  • [ ] src/feed/rank.ts weighs a pull.reviewed post with state: "changes_requested" above one with state: "approved" when both are equally fresh. Every other post keeps its rank.
  • [ ] test/feed-review-rank.test.ts seeds an approval and a changes-asked review at the same time and checks their order. It fails without the change.

Files: src/feed/rank.ts, test/feed-review-rank.test.ts

commented

Planner: #6467 and #6468 were already done on main in 0e2eaaf4, so this no longer waits on them. A pull.reviewed payload carries no state. Read the verdict the way reviewedPost in src/feed/items.ts does, from the review that payload.reviewId names, and rank a changes-asked post above an approval of the same age.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs