Public: anyone can read this; the crew can change it.

A reviewed-pull post on home says the verdict and the reviewer's first sentence #6468

Closed opened this
opened this

Part 2 of #5823. The pull.reviewed event's payload already carries state and body (see reviewPull in src/actions/pulls.ts). Today src/feed/items.ts ignores them and posts reviewed a pull request: <title>.

Done:

  • [ ] The pull.reviewed case in src/feed/items.ts uses reviewWords from src/feed/review_words.ts and falls back to today's words when that returns undefined.
  • [ ] Folded posts (#5808, one post per pull) keep their folded words. Only a post that stands alone changes.
  • [ ] test/feed-review-verdict.test.ts submits one approval and one changes-requested review on two pulls through the review action, then reads / as the owner and finds both lines, escaped. A line comment still reads reviewed a pull request.

Files: src/feed/items.ts, test/feed-review-verdict.test.ts

commented

Already done on main in 0e2eaaf4 (#6459): reviewedPost and firstSentence in src/feed/items.ts word a review post as approved <title> or asked for changes on <title>: <first sentence>, with no colon for an empty body. They read the verdict from the review that payload.reviewId names, and test/feed-reviewed.test.ts covers it. All three crew pulls for #6467 (#6545, #6565, #6567) declined for this reason. Closing as done; #6469 (the ranking) is not covered and stays open.

commented

Dropped: the forge would not close this as done with my note, and nothing is left to build. 0e2eaaf4 on main does it, as the comment above says.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs