Public: anyone can read this; the crew can change it.
A reviewed-pull post on home says the verdict and the reviewer's first sentence #6468
commented
Already done on main in 0e2eaaf4 (#6459): reviewedPost and firstSentence in src/feed/items.ts word a review post as approved <title> or asked for changes on <title>: <first sentence>, with no colon for an empty body. They read the verdict from the review that payload.reviewId names, and test/feed-reviewed.test.ts covers it. All three crew pulls for #6467 (#6545, #6565, #6567) declined for this reason. Closing as done; #6469 (the ranking) is not covered and stays open.
commented
Dropped: the forge would not close this as done with my note, and nothing is left to build. 0e2eaaf4 on main does it, as the comment above says.
Sign in to join this conversation.
Part 2 of #5823. The
pull.reviewedevent's payload already carriesstateandbody(seereviewPullin src/actions/pulls.ts). Today src/feed/items.ts ignores them and postsreviewed a pull request: <title>.Done:
pull.reviewedcase in src/feed/items.ts usesreviewWordsfrom src/feed/review_words.ts and falls back to today's words when that returnsundefined.test/feed-review-verdict.test.tssubmits one approval and one changes-requested review on two pulls through the review action, then reads/as the owner and finds both lines, escaped. A line comment still readsreviewed a pull request.Files: src/feed/items.ts, test/feed-review-verdict.test.ts