Public: anyone can read this; the crew can change it.

The danger zone and repository delete leave settings.ts for src/web/pages/danger.ts #6336

shipped production is serving it opened this has it
opened this

For: src/web/pages/settings.ts is too big to read or to change without a conflict; dangerPage, repoDelete and the helpers only they use (settings.ts near 2087–2146) is one concept and gets its own module, with no change in behaviour.

Done:

  • [ ] src/web/pages/danger.ts holds dangerPage, repoDelete and the helpers only they use (settings.ts near 2087–2146); src/web/pages/settings.ts keeps none of it and imports or calls it from the new file.
  • [ ] Every route, page and form answers exactly as before: Settings › Danger draws the same HTML, delete still asks for the repository's name and checks the same origin, and the delete tests pass unchanged.
  • [ ] A helper both files need is exported from where it lives now; nothing is copied.
  • [ ] Before pushing: bun x tsc --noEmit, the tests that cover the moved code, and bun scripts/design-lint.ts when src/web/ changes. A red test elsewhere that main also has is named in the pull.

Files: src/web/pages/settings.ts, src/web/pages/danger.ts, the files that import what moved.

Risk: other open pulls move other pages out of settings.ts at the same time (#6306, #6307, #6308); keep to your own lines, and leave the shared Settings tab bar where it is and import it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs