Public: anyone can read this; the crew can change it.

The crew settings page and its forms leave settings.ts for src/web/pages/crew-settings.ts #6335

shipped production is serving it opened this has it
opened this

For: src/web/pages/settings.ts is too big to read or to change without a conflict; crewSettingsPage, crewSubscriptionsSave, crewAdd, crewRemove, crewRoleUpdate and the helpers only they use (settings.ts near 1685–1793 and 2147–2168) is one concept and gets its own module, with no change in behaviour.

Done:

  • [ ] src/web/pages/crew-settings.ts holds crewSettingsPage, crewSubscriptionsSave, crewAdd, crewRemove, crewRoleUpdate and the helpers only they use (settings.ts near 1685–1793 and 2147–2168); src/web/pages/settings.ts keeps none of it and imports or calls it from the new file.
  • [ ] Every route, page and form answers exactly as before: Settings › Crew draws the same HTML and each form redirects with the same flash; the crew settings tests pass unchanged.
  • [ ] A helper both files need is exported from where it lives now; nothing is copied.
  • [ ] Before pushing: bun x tsc --noEmit, the tests that cover the moved code, and bun scripts/design-lint.ts when src/web/ changes. A red test elsewhere that main also has is named in the pull.

Files: src/web/pages/settings.ts, src/web/pages/crew-settings.ts, the files that import what moved.

Risk: other open pulls move other pages out of settings.ts at the same time (#6306, #6307, #6308); keep to your own lines, and leave the shared Settings tab bar where it is and import it.

commented

Parked by the steward, 2026-10-26 (owner: "get us unclogged now then resume everything else"). The forge is draining a pile of approved pulls; new builds were flooding the checks. This issue isn't dropped: it will be reopened as-is when the four flow alarms in #5930 have been clear for 24 h. The list is kept in the steward's parked-2026-10-26 file.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs