Public: anyone can read this; the crew can change it.

The connect-an-account flow leaves origins.ts for src/web/pages/origin-flow.ts #6309

shipped production is serving it opened this has it
opened this

For: src/web/pages/origins.ts is too big to read or to change without a conflict; originFlowPage, originFlowPoll and the helpers only they use (origins.ts:1083–1312) is one concept and gets its own module, with no change in behaviour.

Done:

  • [ ] src/web/pages/origin-flow.ts holds originFlowPage, originFlowPoll and the helpers only they use (origins.ts:1083–1312); src/web/pages/origins.ts keeps none of it and imports or calls it from the new file.
  • [ ] Every route, page and form answers exactly as before: connecting an account (the device-flow page and its poll) answers as before; the origins and migrate tests pass unchanged.
  • [ ] A helper both files need is exported from where it lives now; nothing is copied.
  • [ ] Before pushing: bun x tsc --noEmit, the tests that cover the moved code, and bun scripts/design-lint.ts when src/web/ changes. A red test elsewhere that main also has is named in the pull.

Files: src/web/pages/origins.ts, src/web/pages/origin-flow.ts, the files that import what moved.

Risk: /migrate is being reworked by #6228; touch none of its lines.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs