Public: anyone can read this; the crew can change it.

The labels settings page and its forms leave settings.ts for src/web/pages/labels.ts #6306

shipped production is serving it opened this has it
opened this

For: src/web/pages/settings.ts is too big to read or to change without a conflict; labelsPage, labelCreate, labelUpdate, labelDelete and the helpers only they use (settings.ts:1794–1919) is one concept and gets its own module, with no change in behaviour.

Done:

  • [ ] src/web/pages/labels.ts holds labelsPage, labelCreate, labelUpdate, labelDelete and the helpers only they use (settings.ts:1794–1919); src/web/pages/settings.ts keeps none of it and imports or calls it from the new file.
  • [ ] Every route, page and form answers exactly as before: Settings › Labels draws the same HTML, and create, rename and delete still redirect with the same flash; the labels tests pass unchanged.
  • [ ] A helper both files need is exported from where it lives now; nothing is copied.
  • [ ] Before pushing: bun x tsc --noEmit, the tests that cover the moved code, and bun scripts/design-lint.ts when src/web/ changes. A red test elsewhere that main also has is named in the pull.

Files: src/web/pages/settings.ts, src/web/pages/labels.ts, the files that import what moved.

Risk: the Settings tab bar is shared; leave it where it is and import it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs