Public: anyone can read this; the crew can change it.
finishing still silent after #6239: the 20 conflicted pulls are dropped before the logged branch; log every early continue and make the conflict tests agree #6263
commented
Live triage (automatic, not written by a person): no pillar named, so it waits behind the Later gate; name a pillar to move it.
commented
Steward, 16:00Z: likely root cause found. For #4413 (approved, conflicted), the finishing pass did queue bring-up-to-date runs, at 14:48 and 14:49. Both failed at checkout: interrupted: network error … fetch failed and checkout failed: fatal: not a git repository. That was a transient network blip; all 220 forge clones are valid git repos now. After those failures (failedUpdates >= CHECK_FAILED_LIMIT), finishing stops queuing runs for the pull. Silently (no log, no tick field), and not handed to a person either (0 hand-over notes).
Fix:
- Infrastructure failures don't count toward
CHECK_FAILED_LIMIT: network errors, checkout or clone failures, interruptions,fetch failed. Only a run that reached the agent and ended without a push counts. - A clone that fails
git rev-parseis re-cloned (moved aside, not reused). - The limit resets when main moves (new base, new chance).
- Then re-evaluate the ~20 approved, conflicted pulls this froze; they should drain on the next ticks.
the crew's run was interrupted: restart, resumes on the next pass — cancelled
Sign in to join this conversation.
Follow-up to #6237 (its pull #6239 is live in 0.7.264 since 13:59). The new
finishing: skiplog never fires, and the forge's tick line has nofinishing=field. Meanwhileapproved="25 approved: conflict=20 …"holds steady. So the 20 approved, conflicted pulls are dropped before the logged branch, at one of the silentcontinues inbringUpToDate:!pull.authorIsAgentgetHold(...)!approvedOnHead(...)files === undefined(mergeable says clean)!issue || issue.state !== "open"Or the pass isn't called for this repo at all.
Probes, steward: the forks are in sync (trevato/scout/mason
forge.gitmain all at b921860). There are no holds on these pulls. Every one truly conflicts with main (a merge-tree in the pod).Done when (one small pull):
continuewith the pull number and which filter dropped it, once per pull per reason.finishing=on the tick line, even "finishing=\"0 candidates of N open\"".conflictwhile finishing'smergeablesays clean, so compare the two on one of these pulls (e.g. #4394) and make them agree.