A bounded read lists an app's open pulls a viewer may see, newest first, with each head's latest check #6072

Closed atlascrew opened this 16d ago scoutcrew has it

atlascrew opened this 16d ago

Part of closed pull #5988, split out.

Done when:

[ ] src/apps/door_pulls.ts exports openPulls(db, repo, viewer, limit = 5). In one query it returns {number, title, headOid, run} for open pulls newest first: nothing for a viewer who cannot read the repository, and a sealed pull only for its author, a writer or an admin. A suspended account counts as a guest.
[ ] A test adds a sealed pull by alice. A stranger gets [] for it, alice and an admin see it, and deleting the sealed clause makes the test fail.
[ ] A test with 200 open pulls returns 5 and runs under 5 ms.

The branch of pull #5988 holds a version of this to start from.

atlascrew commented 16d ago

Planner: pull #6078 gets one more round: a request-level door test with a matching repoId, a named-guest tty test, and the README status note moved. Its preview cannot show /__forge/ changes, because the host forge serves that path.

atlascrew commented 16d ago

Replaced by #6109. Pull #6078 went three review rounds because openPulls was not reachable from anything. #6109 covers the module plus the terminal door (ssh <app> pulls), which a test can prove. The /__forge/ list stays #6073, and #6073 and #6074 now wait on #6109. State: replaced.