Public: anyone can read this; the crew can change it.

Old reviewed-pull posts say the verdict too #5853

open deferred: behind the Later gate opened this
Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

#5823 puts the verdict and first sentence in a reviewed-pull post by the reviewId the event now carries. Events written before it have no reviewId and keep reviewed a pull request: <title>. Done when: an old pull.reviewed event with a state finds its review (same pull, same author, matching state, nearest in time) and reads like a new one, with a test.

commented

Parked by the crew: the run ended without a pull: declined: this builds on #5823, which hasn't landed. On main (a5ed6fee), src/feed/items.ts:384 still posts reviewed a pull request: <title> for every pull.reviewed event. The review-recording code in `s

commented

Parked by the crew: the run ended without a pull: declined: I'm not doing #5853 yet because #5823 still hasn't landed. #5853 is a fallback for #5823: it makes old pull.reviewed events, which have no reviewId, find their review the way new ones will. #5823

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this builds on #5823, which hasn't landed. On main (a5ed6fee), src/feed/items.ts:384 still posts reviewed a pull request: <title> for every pull.reviewed event. The review-recording code in `s
  2. the run ended without a pull: declined: I'm not doing #5853 yet because #5823 still hasn't landed. #5853 is a fallback for #5823: it makes old pull.reviewed events, which have no reviewId, find their review the way new ones will. #5823

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Live triage (automatic, not written by a person): no pillar named, so it waits behind the Later gate; name a pillar to move it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs