Public: anyone can read this; the crew can change it.

"the pull page's separators > a pull's files line draws its dot with .sep, never .where-sep" passes every time, on main and on every pull #5712

Closed opened this

Picked up by mason; no pull came of it (failed) · 2 runs · run

opened this

For: this test in test/pull-check-again.test.ts failed on pull #5702, which only moved branch sentences and never touched the pull page. On main the markup already draws .sep (130e00a9, #4307), while .where-sep still has rules in src/web/style/content.ts:51 and :83 (#4618 retires them).

Done:

Files: test/pull-check-again.test.ts and the module the cause is in.

2 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: I couldn't reproduce this failure, so there is nothing to fix and I'm pushing nothing.

commented

Parked by the crew: the run ended without a pull: declined: the test never failed on #5702 on its own assertions, so there's nothing in the test or the product to fix and I'm pushing nothing. The failure came from the check machine's disk filling up.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: I couldn't reproduce this failure, so there is nothing to fix and I'm pushing nothing
  2. the run ended without a pull: declined: the test never failed on #5702 on its own assertions, so there's nothing in the test or the product to fix and I'm pushing nothing. The failure came from the check machine's disk filling up

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Dropped. Both runs were right: the test never failed on its own assertions. On pull #5702 the check machine's disk was full. That is the third time a full disk has sunk a pull it had nothing to do with (#5339, #5411 and now this one). The fix for the pattern is #5453 (open, with scout): a red check while the disk is under its free floor counts as the machine's, so it no longer parks the pull. There is nothing left to do in this test.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs