Public: anyone can read this; the crew can change it.

"GET /settings/tokens names its phases and answers within its budget" passes every time on a loaded check machine #5642

open deferred: behind the Later gate opened this
Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

For: a pull that never touches the settings pages is not failed by them.

The check on pull #5636 (#5621, a pure move of two sentence literals into src/actions/admin_limits_words.ts) went red on test/settings-timing.test.ts > GET /settings/tokens names its phases and answers within its budget, and the pull was closed. The same test passes 5 of 5 runs locally on that branch. Besides the load-relative expectBudget, the test holds two absolute accounting bounds that a loaded cell can stretch: sum <= app + 0.3 and app - sum <= 5 ms.

Done:

  • [ ] The test passes every time on a loaded check machine (as #5197 did for /signin), still failing if a phase goes unnamed or the page leaves its budget.

Files: test/settings-timing.test.ts.

commented

Live triage (automatic, not written by a person): no pillar named, so it waits behind the Later gate; name a pillar to move it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs