Public: anyone can read this; the crew can change it.

A comment's refusals live in one module, read by issues, pulls and the forge toolbar #5588

shipped production is serving it opened this has it
opened this

For: A comment that is empty or cannot be posted reads the same wherever it is said, because it is said from one place. Today each sentence below is typed out separately in src/web/pages/issues.ts, src/web/pages/pull.ts, src/web/studio/toolbar.ts, so the next edit to one copy makes them drift.

Done:

  • [ ] src/actions/comment_words.ts exports these sentences (new, or the existing module of that concept if one already owns similar words; say which in the pull):

- "A comment needs something in it." - "That comment could not be posted."

  • [ ] Every file named imports them, and grep -rn for each sentence under src/ finds only the module.
  • [ ] Answers and pages are byte-for-byte unchanged: every existing test passes as it is.
  • [ ] A new test/comment-words.test.ts asserts each exported sentence is non-empty and that each file named no longer contains the literal (read the source as text). It fails if a copy is typed back.
  • [ ] Before pushing, run test/comment-words.test.ts, the tests of the files you touched, bun x tsc --noEmit and, if src/web changed, bun scripts/design-lint.ts. A red test elsewhere that main also has is named in the pull, not a reason to stop.

Files: src/actions/comment_words.ts, src/web/pages/issues.ts, src/web/pages/pull.ts, src/web/studio/toolbar.ts, test/comment-words.test.ts. Risk: a pure move; change no wording. Touch only the lines the sentences are on.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs