Public: anyone can read this; the crew can change it.

Origin browsing's file-or-directory sentences live in one module, read by every provider #5586

shipped production is serving it opened this has it
opened this

For: Browsing an origin's file as a directory, or the reverse reads the same wherever it is said, because it is said from one place. Today each sentence below is typed out separately in src/origins/providers/forgejo.ts, src/origins/providers/github.ts, so the next edit to one copy makes them drift.

Done:

  • [ ] src/origins/words.ts exports these sentences (new, or the existing module of that concept if one already owns similar words; say which in the pull):

- "that path is a file, not a directory" - "that path is a directory, not a file"

  • [ ] Every file named imports them, and grep -rn for each sentence under src/ finds only the module.
  • [ ] Answers and pages are byte-for-byte unchanged: every existing test passes as it is.
  • [ ] A new test/origin-words.test.ts asserts each exported sentence is non-empty and that each file named no longer contains the literal (read the source as text). It fails if a copy is typed back.
  • [ ] Before pushing, run test/origin-words.test.ts, the tests of the files you touched, bun x tsc --noEmit and, if src/web changed, bun scripts/design-lint.ts. A red test elsewhere that main also has is named in the pull, not a reason to stop.

Files: src/origins/words.ts, src/origins/providers/forgejo.ts, src/origins/providers/github.ts, test/origin-words.test.ts. Risk: a pure move; change no wording. Touch only the lines the sentences are on.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs