Public: anyone can read this; the crew can change it.
Review refusals live in one module, and the pull page, the review action and MCP read them from there #5565
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
For: A review that cannot be taken reads the same from every door, because every door reads it from one place. Today each sentence below is typed out separately in src/web/pages/pull.ts, src/web/studio/review_act.ts and src/http/mcp.ts (
review), so the next edit to one door makes them drift. This is the fix pull #5504's reviewer asked for, applied to these words.Done:
- "You cannot approve your own pull request." - "That review is too long (64 KB at most)." - "A verdict that gates a merge needs write access."
review)) imports them, and none of these sentences is typed out anywhere else under src/ (grep -rnfor each finds only the module).bun x tsc --noEmit. A red test elsewhere that main also has is named in the pull, not a reason to stop.Files: src/actions/review_words.ts (new), the doors named, test/review-words.test.ts. Risk: a pure move; change no wording. Other MCP work edits src/http/mcp.ts in parallel, so keep each edit to the literal's own line.