Public: anyone can read this; the crew can change it.

The Server-Timing sweep treats a redirect as a redirect: /:owner/:name/tells and /changes leave its debt list #5413

shipped production is serving it opened this has it
opened this

For: test/server-timing-sweep.test.ts lists /alice/forge/tells and /alice/forge/changes as pages that still need phases. Both are now movedTo("issues") and movedTo("pulls") redirects (src/http/server.ts:1095 and :1166). Their issues, #3322 and #3323, are closed, so the lines are debt no one will pay.

Done:

  • [ ] The sweep treats a 3xx answer as not a page, with no phases expected. The two lines leave UNNAMED.
  • [ ] A real page that starts answering 3xx is caught: the sweep asserts every route it skips as a redirect is one it can name (an explicit set), so a page cannot slip out by redirecting.

Files: test/server-timing-sweep.test.ts only.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs