Public: anyone can read this; the crew can change it.

/-/confirm and the parent sign-in pages name their Server-Timing phases #5401

shipped production is serving it opened this has it
opened this

For: the confirm page (confirmPage, src/web/pages/search.ts) and the sign-in-with-your-parent-forge pair (/signin/parent and /signin/parent/callback, src/http/rp.ts) are on the trust path. When one is slow, it should say whether the session, the read or the parent round-trip was slow.

Done:

  • [ ] /-/confirm marks session and render. /signin/parent marks session and render. /signin/parent/callback marks session and parent (the token exchange with the parent forge, timePhaseAsync).
  • [ ] Their lines leave UNNAMED in test/server-timing-sweep.test.ts, and that sweep passes.
  • [ ] A new test, test/confirm-parent-timing.test.ts, asserts the phase names on each route and fails without the change.
  • [ ] Bodies and status codes are unchanged.

Files: src/web/pages/search.ts, src/http/rp.ts, test/server-timing-sweep.test.ts, test/confirm-parent-timing.test.ts. Why: the sweep lists these pages against #3390, which was closed as dropped, so no open issue would ever take them off.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs