Public: anyone can read this; the crew can change it.

The OpenAPI document describes a pull's review threads: list, resolve and reopen #5381

shipped production is serving it opened this has it
opened this

Done:

  • [ ] Rows for GET …/pulls/{number}/threads, and POST and DELETE …/pulls/{number}/threads/{anchor}/resolve. Each row sits in ROUTES (src/contract/openapi.ts) in its own block after the {REPO}/pulls/{number}/merge row. It says what the route answers, whether it needs a token, and its body fields and refusals, all read from the handler in src/http/api.ts, and it uses the method the handler registers. The routes' lines leave NOT_YET_DESCRIBED in test/openapi-coverage.test.ts.
  • [ ] A case in test/openapi-oa-pull-threads.test.ts reads the rows from /api/v1/openapi.json and fails without them. test/openapi.test.ts and test/openapi-coverage.test.ts pass.
  • [ ] Before pushing, run those tests and bun x tsc --noEmit. A red test elsewhere that main also has is named in the pull, not a reason to stop.

Files: src/contract/openapi.ts, test/openapi-coverage.test.ts, test/openapi-oa-pull-threads.test.ts. Split from #4851, which was too many routes for one run and went red twice.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs