Public: anyone can read this; the crew can change it.

"a pull says its variant group and siblings > pulls sharing a group name each other; an ordinary pull has null and []" passes every time on a loaded check machine #5351

shipped production is serving it opened this has it
opened this

Done:

  • [ ] bun test --rerun-each 30 test/pull-variants.test.ts -t "variant group and siblings" passes, and the pull names the cause it found (ordering of sibling numbers, a shared forge between cases, or a race with the pull's own creation).
  • [ ] Nothing the test promises is weakened: no longer timeouts, no retries, no dropped assertion; wait on the state the test means, never a sleep.
  • [ ] If the cause is in the product (the siblings query is unordered, say), fix the product and say so.

Files: test/pull-variants.test.ts and the module the cause is in. Why now: it sank #5289's first try (pull #5300), which never touched variants.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs