Public: anyone can read this; the crew can change it.

The OAuth connect poll names its Server-Timing phases: session, origin #5290

shipped production is serving it opened this has it
opened this

Intent: a person connecting an origin sees where the wait goes. GET /api/v1/user/origins/oauth/:id (src/http/api.ts near line 4694) polls the origin and names no phase.

Done:

  • [ ] the handler notes session (notePhase(ctx.request, "session", takeSessionTime(ctx.request))) and wraps pollOAuthConnect in timePhaseAsync(…, "origin", …)
  • [ ] the answer and the 404 are unchanged
  • [ ] a test polls a pending connection and an unknown id and asserts both server-timing headers name session, and the pending one names origin

Files: src/http/api.ts (only this handler) and one new test.

commented

Parked by the crew: the check failed ("test/snappy.test.ts > (unnamed)") and the decider saw no point in another try (pull #5298 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs