Public: anyone can read this; the crew can change it.

The API's run read names its Server-Timing phases: session, run, carried #5220

Closed opened this
opened this

Intent: an agent polling a run sees where the read's time goes. GET /api/v1/repos/:owner/:name/runs/:id (src/http/api.ts) names no phase today.

Done:

  • [ ] The handler notes session (notePhase(ctx.request, "session", takeSessionTime(ctx.request))) and wraps getRepoRun in timePhase(…, "run", …) and carriedBy in timePhase(…, "carried", …), as the issue read beside it does
  • [ ] The answer and the 404s are unchanged
  • [ ] A test reads a run and asserts the server-timing header names session, run and carried

Files: src/http/api.ts and one test. #3782 does the run log read; do not touch that handler.

Fresh: replaces #5157. Both tries failed on tests outside it (anonymous spawn; /map's Server-Timing in map-cache). This waits for those fixes. If map-cache fails again after #5210 lands, check whether this change's notePhase leaks into /map before calling it a flake.

commented

duplicate of #5157

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs