Public: anyone can read this; the crew can change it.

The sentinel does not refile an incident whose issue the planner closed as split or dropped #5149

shipped production is serving it opened this has it
opened this

Intent: no red noise. #5104 was closed as split into #5109, #5110 and #5111 at 06:25, and at 06:33 the sentinel filed #5130 with the same cause and the same first-open time. continuesDone in src/crew/sentinel.ts only recognises a close reason of done.

Done:

  • [ ] In hunt, a finding whose sentinel_finding row (same key, same incident) belongs to an issue closed as split or dropped files no new issue. When the closed issue was split, the sentinel comments on it at most once a day, as continuesDone does. When it was dropped it stays silent
  • [ ] A new incident (a different first-open time) for the same key is still filed as a new issue
  • [ ] Tests in the sentinel suite: closed as split with the same incident → no new issue, at most one comment a day; closed as dropped → nothing; a new incident → a new issue. The first two fail on today's main

Files: src/crew/sentinel.ts and its test. Run the sentinel tests and test/sentinel*.test.ts before pushing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs