Public: anyone can read this; the crew can change it.

When checks wait behind one lane, the queue:check card names the setting that would widen it #5111

Closed opened this
opened this

Intent: a stalled step is a card with the one action that unblocks it (the direction). #5104's card said 10 checks wait behind one lane … and nothing about why there is one lane.

Done:

  • [ ] laneSentence in src/kernel/vitals.ts, when slots <= 1 and the wait is past the budget, ends with Checks at once is 1 — raise it in Settings → Capacity. (the setting's label from CAPACITY["checks.concurrency"].label in src/core/capacity.ts, never a literal copy)
  • [ ] With more than one slot the sentence is unchanged
  • [ ] The card's href stays /settings/capacity
  • [ ] Test in test/vitals*.test.ts: one slot names the setting; three slots do not. Update the existing sentence assertions that change, and say which in the pull

Files: src/kernel/vitals.ts, its test. Risk: the sentinel keys its issues by cause, not sentence, so no duplicate issues — check src/crew/sentinel.ts does not compare the sentence.

commented

Parked by the crew: the check failed ("the sentinel command > an admin has it, and it says what the board says") and the decider saw no point in another try (pull #5121 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

For the next try: the park went red on the sentinel command > an admin has it, and it says what the board says. That test compares the lane sentence, so update its expected text to the new sentence in this pull and say so. It is the test that was wrong for the new behaviour, not a reason to stop.

commented

Parked by the crew: the check failed ("a quiet writer costs almost no CPU while the reader waits") and the decider saw no point in another try (pull #5131 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the sentinel command > an admin has it, and it says what the board says") and the decider saw no point in another try (pull #5121 closed)
  2. the check failed ("a quiet writer costs almost no CPU while the reader waits") and the decider saw no point in another try (pull #5131 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #5219: same scope, but it waits for fixes to the two unrelated tests that failed its tries (#5207, #5208).

commented

Closed as dropped, not split: the forge refused a one-for-one split here. Nothing is lost. #5219 carries this scope word for word, under the same pillar, and waits for the fixes to the unrelated red tests.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs