Public: anyone can read this; the crew can change it.

The API's contribute welcome names its Server-Timing phases: session, welcome, render #5012

shipped production is serving it opened this has it
opened this

Done: GET /api/v1/contribute answer a Server-Timing header naming session, welcome, render, in that order, the way GET …/tags does (notePhase(ctx.request, "session", takeSessionTime(ctx.request)), then timePhase/timePhaseAsync around the read and around json(…)). The bodies, status codes and access rules do not change.

  • [ ] Each route above names its phases; a refused read (401/403/404) still names session.
  • [ ] One test per route asserts the header's phase names in order (pattern: test/crew-timing.test.ts), and fails without the change.
  • [ ] bun test for the touched files passes.

Files: src/http/api.ts, one new test file. Risk: none to behaviour; keep the access check outside the read's phase, and never put a name, token or value in a phase.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs