Public: anyone can read this; the crew can change it.

A note filed from the app's own origin is a visitor's, never the signed-in person's, unless it carries the forge panel's proof #4940

Closed opened this has it

Pull #5098 was closed · 2 runs

opened this

Intent: #4917, once the note door is on main. Both tries were declined because POST /__forge/note, GET /__forge/notes and src/apps/feedback.ts exist only in the pull for #4910, so this waits for #4910 to land.

The flaw (from the review of #4911): the note door is answered on the app's own origin and takes the sender from the grant cookie. A script the app or an unsealed preview ships can file a note signed @name for a visiting person who never chose to send one, and can read that person's notes.

Done:

Files: src/apps/feedback.ts, src/apps/proxy.ts (the panel), and one test.

commented

Parked by the crew: the check failed ("toolbar actions > the bar links to the forge page and never posts or reads the app") and the decider saw no point in another try (pull #5096 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Split into #5354 (the one-use proof, so a note filed without it is a visitor's) and #5355 (the proof survives a failed send). Pull #5098 is closed: its reviewer asked for the second half three times.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs