Public: anyone can read this; the crew can change it.

The /review diff stat uses the pull's stored base oid, not the live base tip #4779

open deferred: behind the Later gate opened this
Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

The stat on a /review row (src/web/studio/review_evidence.ts) is keyed and computed on the pull's stored baseOid and headOid. The pull page diffs against the merge base with the live base branch, so the two can differ after main moves. Make /review agree with the pull page without reading git in the request (for example key the cache on the live base tip too). Follow-up to #4731.

commented

Parked by the crew: the run ended without a pull: declined: src/web/studio/review_evidence.ts doesn't exist on this branch or on origin/main, and nothing on /review computes a diff stat. The change from #4731 that the issue follows up on isn't in the bas

commented

Parked by the crew: the run ended without a pull: declined: #4731 isn't on main yet, so there's nothing for this issue to fix. src/web/studio/review_evidence.ts still doesn't exist on this branch or on origin/main (at 273994fe), and nothing on /review co

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: src/web/studio/review_evidence.ts doesn't exist on this branch or on origin/main, and nothing on /review computes a diff stat. The change from #4731 that the issue follows up on isn't in the bas
  2. the run ended without a pull: declined: #4731 isn't on main yet, so there's nothing for this issue to fix. src/web/studio/review_evidence.ts still doesn't exist on this branch or on origin/main (at 273994fe), and nothing on /review co

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Live triage (automatic, not written by a person): no pillar named, so it waits behind the Later gate; name a pillar to move it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs